Skip to content

feat(search): manage source permissions through a shared API and CLI - #9845

Merged
waleedlatif1 merged 2 commits into
stagingfrom
codex/search-source-permissions
Nov 10, 2026
Merged

feat(search): manage source permissions through a shared API and CLI#9845
waleedlatif1 merged 2 commits into
stagingfrom
codex/search-source-permissions

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Nov 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Summary

  • Read and replace Search source permissions through one API and CLI command group. Each connector defines the grant format it accepts.
  • Keep authorization, revision checks, and atomic grant replacement in the shared path. Update the GitLab CI example and generated references.

Type of Change

  • Improvement

Testing

  • Ran the public HTTP end-to-end suite against Sim and PostgreSQL, including concurrent replacements, revoked access, malformed uploads, and unsupported sources.
  • Ran the CLI and documented CI job against a running Sim instance. With two signed-in users and a GitLab fixture, the replacement granted one reader access and revoked search and document reads for the other.
  • Ran the permission store integration tests, all 527 CLI tests, docs compatibility, lint, type-check, and all 62 repository audits.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Nov 10, 2026 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Nov 10, 2026 7:12pm UTC

Request Review

cubic-dev-ai[bot]
cubic-dev-ai Bot reviewed Nov 10, 2026
View reviewed changes

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 25 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Nov 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; the latest changes address the earlier documentation finding.

Summary

The PR moves Search source permissions to a shared API and CLI command group.

  • Admins and CI can manage Search source grants through shared permission commands.

Diagram

 
%%{init: {'theme': 'neutral'}}%%
flowchart LR
  A[API or CLI] --> B[Check organization admin access]
  B --> C[Find the source and permission capability]
  C --> D[Prepare provider grants]
  D --> E[Lock source and check revision]
  E --> F[Save snapshot and grants together]
Loading

Reviews (2) · Last reviewed commit: "chore(search): document the shared permi..." · Reviewed by Greptile

@waleedlatif1

waleedlatif1 commented Nov 10, 2026

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

waleedlatif1 commented Nov 10, 2026

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 10, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai[bot]
cubic-dev-ai Bot reviewed Nov 10, 2026
View reviewed changes

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 25 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit 5836fce into staging Nov 10, 2026
60 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/search-source-permissions branch November 10, 2026 19:16
@waleedlatif1 waleedlatif1 mentioned this pull request Nov 11, 2026
Merged

This branch was previously deployed

1 inactive deployment
Preview — ef17ff30 Deployed Nov 10, 2026 by vercel[bot]
View deployment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@greptile-apps greptile-apps[bot] greptile-apps[bot] left review comments
@cubic-dev-ai cubic-dev-ai[bot] cubic-dev-ai[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@waleedlatif1